Prestashop Core Application V1.5

Double semi-colons in code

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Security Level: All-users
  • Labels:
    None
  • Similar issues:
    PSCFV-7788 Change default CSV field separators
    PSCFV-6377 porducts double
    PSCFV-3927 Double entries in webservice api/images/products
    PSCFV-5352 translation double quote
    PSCFV-6582 Double rule for taxes
    PSCFV-8821 Changing language doubles footer content

Description

You have some double semi-colons in the code - see text file attached.

(some may be intentional, of course)

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Damien METZGER added a comment - 13/Jul/12 9:15 AM

Thank you for your report.

Show
Damien METZGER added a comment - 13/Jul/12 9:15 AM Thank you for your report.
Hide
Permalink
Pixel added a comment - 13/Jul/12 5:11 PM

Hi Damian,

Have you missed some?

/tools/smarty/sysplugins/smarty_internal_compile_include.php:206: $_output = "<?php \$_smarty_tpl->tpl_vars[$_assign] = new Smarty_variable(\$_smarty_tpl->getSubTemplate ($include_file, $_cache_id, $_compile_id, $_caching, $_cache_lifetime, $_vars, $_parent_scope));?>\n";;

/admin-dev/themes/default/template/controllers/products/informations.tpl:335: <span class="hint" name="help_box">{l s='Forbidden characters:'} !<;>;?=+#"°{}_$%<span class="hint-pointer"> </span></span>

/js/admin_order.js:417: $('#add_product_product_stock').css('font-weight', 'normal').css('color', 'black').css('font-size', '1em');;

Show
Pixel added a comment - 13/Jul/12 5:11 PM Hi Damian, Have you missed some? /tools/smarty/sysplugins/smarty_internal_compile_include.php:206: $_output = "<?php \$_smarty_tpl->tpl_vars[$_assign] = new Smarty_variable(\$_smarty_tpl->getSubTemplate ($include_file, $_cache_id, $_compile_id, $_caching, $_cache_lifetime, $_vars, $_parent_scope));?>\n";; /admin-dev/themes/default/template/controllers/products/informations.tpl:335: <span class="hint" name="help_box">{l s='Forbidden characters:'} !<;>;?=+#"°{}_$%<span class="hint-pointer"> </span></span> /js/admin_order.js:417: $('#add_product_product_stock').css('font-weight', 'normal').css('color', 'black').css('font-size', '1em');;
Hide
Permalink
Damien METZGER added a comment - 13/Jul/12 5:15 PM

Hello,

As you said, some are intentional, this is the case for informations.tpl.
As for smarty_internal_compile_include.php, this is an external library, I won't modify it since it will be lost with the next update.
However, I missed the one in admin_order.js indeed!

Regards,

Show
Damien METZGER added a comment - 13/Jul/12 5:15 PM Hello, As you said, some are intentional, this is the case for informations.tpl. As for smarty_internal_compile_include.php, this is an external library, I won't modify it since it will be lost with the next update. However, I missed the one in admin_order.js indeed! Regards,

People

Vote (0)
Watch (0)

Dates

  • Created:
    12/Jul/12 9:28 PM
    Updated:
    13/Jul/12 5:15 PM
    Resolved:
    13/Jul/12 5:15 PM
Atlassian JIRA (v4.2.4-b591#591) | Report a problem
Powered by a free Atlassian JIRA open source license for Prestashop SA. Try JIRA - bug tracking software for your team.